When disc has more than two discs may not match because can match songs to wrong disc

Description

08/07/2015 23.29.52:com.jthink.jaikoz.manipulate.scoring.Matrix:showMatrix:CONFIG: 686bb78d-f3c3-41d0-b07f-84b1d03906f7TrackMatrix:SongCount:2:TrackCount:23
08/07/2015 23.29.52:com.jthink.jaikoz.manipulate.scoring.Matrix:showMatrix:CONFIG: 686bb78d-f3c3-41d0-b07f-84b1d03906f7:song 0:Axel Fischer - Cha La La I Need You.mp3: 0, 20, 0, 0, 10, 15, 10, 20, 15, 25, 0, 0, 6, 15, 0, 25, 0, 0, 0, 0, 0, 20, 5,
08/07/2015 23.29.52:com.jthink.jaikoz.manipulate.scoring.Matrix:showMatrix:CONFIG: 686bb78d-f3c3-41d0-b07f-84b1d03906f7:song 1:Frank Lukas - Leider Geil.mp3: 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 20, 25, 0, 0, 0, 0, 0, 0, 10, 22, 0, 0, 0,
0
.....
08/07/2015 23.29.45:com.jthink.jaikoz.manipulate.scoring.Scorer:calculateReleaseScore:INFO: GROUP 33:_Audio_Fertig:Ballermann Hits 2014 XXL (disc 2):686bb78d-f3c3-41d0-b07f-84b1d03906f7:Medium:1:Matched:2
08/07/2015 23.29.45:com.jthink.jaikoz.manipulate.scoring.Scorer:calculateReleaseScore:INFO: GROUP 33:_Audio_Fertig:Ballermann Hits 2014 XXL (disc 2):686bb78d-f3c3-41d0-b07f-84b1d03906f7:Total Matched:2 from 2
08/07/2015 23.29.45:com.jthink.jaikoz.manipulate.scoring.Scorer:calculateReleaseScore:INFO: GROUP 33:_Audio_Fertig:Ballermann Hits 2014 XXL (disc 2):686bb78d-f3c3-41d0-b07f-84b1d03906f7:Ballermann Hits 2014 XXL:Successful Match
0

......
08/07/2015 23.29.55:com.jthink.jaikoz.manipulate.musicbrainzhelper.MusicBrainzScorer:checkAcoustid:INFO: GROUP 33:_Audio_Fertig:Ballermann Hits 2014 XXL (disc 2):Release rejected no match between:The One:Leider Geil

Activity

Show:
Paul Taylor
July 9, 2015, 10:11 AM
Edited

Jaikoz grouped two songs for the purposes of release matchiug

This release has more than two discs so when find a match (only 25/100) for both tracks on disc 1 of this release so we dont attempt to check any other discs !

Then the double check on Acoustid for the matches reveals they are not good matches and therefore the match is rejected.

but no attempt is ever made to check against additional discs.

We do matching per disc and stop once all tracks have been matched for diss with more than two discs because creating a matching matrix for all tracks in release in one go in these cases typically uses too much memory and cpu, but the disc by disc matching is not as comprehensive as normal matching

Paul Taylor
July 10, 2015, 10:32 AM

We have solved this by changing how we do matching for single songs, single song matching now checks all tracks of a release, even large releases because when only have one song can do it without hitting cpu/memory limits. So although the above match would still fail subsequent single song match for these songs should work.

Fixed

Reporter

Paul Taylor

Labels

None

Forum Username

alfg

os

None

Fix versions

Affects versions

Priority

Major
Configure