Unable to save file because not filtering outs dots from metadata

Description

If do Correct SubFolder from Metadata and the metadata used has a value ending in dots (...) the value gets copied to the SubFolder column instead of being corrected, then if you try and save the save will fail because it is an invalid filename

Replicated on Windows

Activity

Show:
Paul Taylor
September 28, 2016, 12:10 PM

Also

I did the file/folder rename, and albums with the (...) in them are causing an issue saving. Apparently FOLDERS ending in a period are not allowed. (I didn't know that, news to me) Periods are OK in the middle. [On Windows] I do not know about Linux or Mac.

So then there's also an issue with the behavior of what happened:

Sep 23, 2016 1:05:59 AM: SEVERE: There was a problem changing some files,these have been left with status of changed
Sep 23, 2016 1:05:59 AM: SEVERE: Unable to rename file to:Z:\MP3Done\Godsmack\All Wound Up...\Godsmack - All Wound Up... - 04 - Keep Away.mp3
Sep 23, 2016 1:05:59 AM: SEVERE: Unable to rename file to:Z:\MP3Done\DJ Shadow\Endtroducing.....\DJ Shadow - Endtroducing..... - 03 - The Number Song.mp3
Sep 23, 2016 1:05:59 AM: SEVERE: Unable to rename file to:Z:\MP3Done\DJ Shadow\Endtroducing.....\DJ Shadow - Endtroducing..... - 04 - Changeling Transmission 1.mp3
Sep 23, 2016 1:05:59 AM: SEVERE: Unable to rename file to:Z:\MP3Done\DJ Shadow\Endtroducing.....\DJ Shadow - Endtroducing..... - 10 - Why Hip Hop Sucks in '96.mp3
Sep 23, 2016 1:05:59 AM: SEVERE: Unable to rename file to:Z:\MP3Done\DJ Shadow\Endtroducing.....\DJ Shadow - Endtroducing..... - 11 - Midnight in a Perfect World.mp3

This was after a "save and Move". When you save and move, after saving the file is closed. So the message said the file was left as changed, but what happened when it couldn't save, it closed the file

Paul Taylor
October 20, 2016, 11:58 AM
Edited

No the problem is the FOLDERSEPERATORPLACEHOLDER code that was added to prevent problems when generating filenames form metadata such as 'AC/DC' has caused problems breaking the regular expressions that check for invalid chars in the subfolder checking. The problem only occurs with Rename SubFolder from Metadata not when user manually edits.

Paul Taylor
October 20, 2016, 3:47 PM

Fixed

Paul Taylor
October 20, 2016, 3:47 PM

Done.

Reporter

Paul Taylor

Labels

None

Forum Username

ravenxxx

os

None

Fix versions

Affects versions

Priority

Major
Configure