We're updating the issue view to help you get more done. 

Removal of Lock on Save can cause problems with M4as because can use temporary files.

Description

Removal of Lock on Save can cause problems with M4as because can use temporary files.

05/07/2018 15.48.47:EDT:com.jthink.songkong.analyse.analyser.FileRenamer:moveEverything:SEVERE: Failed moving associated file from(0) D:\Music Storage\iTunes\Music\Whitney Houston\The Greatest Hits [Disc 2]\16 Greatest Love Of All (Junior Vasq_m4a2038577890773330025.tmp to D:\Music Storage\iTunes\Whitney Houston\The Greatest Hits (disc 2 Throw Down) because IOException
java.io.IOException: Failed to delete original file 'D:\Music Storage\iTunes\Music\Whitney Houston\The Greatest Hits [Disc 2]\16 Greatest Love Of All (Junior Vasq_m4a2038577890773330025.tmp' after copy to 'D:\Music Storage\iTunes\Whitney Houston\The Greatest Hits (disc 2 Throw Down)\16 Greatest Love Of All (Junior Vasq_m4a2038577890773330025.tmp'
at org.apache.commons.io.FileUtils.moveFile(FileUtils.java:2664)
at org.apache.commons.io.FileUtils.moveFileToDirectory(FileUtils.java:2700)
at com.jthink.songkong.analyse.analyser.FileRenamer.moveEverything(FileRenamer.java:658)
at com.jthink.songkong.analyse.analyser.FileRenamer.renameFile(FileRenamer.java:615)
at com.jthink.songkong.analyse.analyser.SongSave.saveRenamedFile(SongSave.java:998)
at com.jthink.songkong.analyse.analyser.SongSave.realSave(SongSave.java:738)
at com.jthink.songkong.analyse.analyser.SongSave.call(SongSave.java:173)
at com.jthink.songkong.analyse.analyser.SongSave.call(SongSave.java:73)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

Solution,

1. Best solution, Fix jaudiotagger to not use any temporary files
2. Otherwise need to reintroduce lock to SongSaver

Environment

None

Status

Assignee

Unassigned

Reporter

IJabz

Labels

None

Forum Username

PeterBolden

os

None

Affects versions

9.3.0

Priority

Major