NullPointer saving artwork if writing song to root

Description

25/01/2021 09.09.46:EST:SongSave:handleFailedSaveErrors:SEVERE: Unable to save changes:/Ace of Base - All That She Wants: The Classic Collection - 01 - 05 - Living in Danger.mp3 class java.lang.NullPointerException
java.lang.NullPointerException
at com.jthink.songkong.analyse.analyser.SongSaveArtworkFilesystem.saveAlbumArtworkToFilesystem(SongSaveArtworkFilesystem.java:111)
at com.jthink.songkong.analyse.analyser.SongSave.call(SongSave.java:224)
at com.jthink.songkong.analyse.analyser.SongSaver.saveSongsToFile(SongSaver.java:474)
at com.jthink.songkong.analyse.analyser.SongSaver.saveChanges(SongSaver.java:238)
at com.jthink.songkong.analyse.analyser.SongSaver.call(SongSaver.java:205)
at com.jthink.songkong.analyse.analyser.SongSaver.call(SongSaver.java:51)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
25/01/2021 09.09.46:EST:Errors:addError:SEVERE: Adding Error:Unable to save changes: /Ace of Base - All That She Wants: The Classic Collection - 01 - 05 - Living in Danger.mp3 class java.lang.NullPointerException
java.lang.Exception
at com.jthink.songkong.analyse.general.Errors.addError(Errors.java:28)
at com.jthink.songkong.analyse.analyser.SongSave.handleFailedSaveErrors(SongSave.java:454)
at com.jthink.songkong.analyse.analyser.SongSave.call(SongSave.java:242)
at com.jthink.songkong.analyse.analyser.SongSaver.saveSongsToFile(SongSaver.java:474)
at com.jthink.songkong.analyse.analyser.SongSaver.saveChanges(SongSaver.java:238)
at com.jthink.songkong.analyse.analyser.SongSaver.call(SongSaver.java:205)
at com.jthink.songkong.analyse.analyser.SongSaver.call(SongSaver.java:51)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)

See https://community.jthink.net/t/problems-with-songkong-file-renaming-on-nas/9770/5

Activity

Show:
IJabz
January 28, 2021, 8:29 PM

fixed, due to logic for writing artwork to parent album folder (if muti-album with disc folder) wasnt checking that parent folder wasnt null.

Fixed

Reporter

IJabz

Labels

None

Forum Username

draffutt

os

None

Components

Fix versions

Affects versions

Priority

Major