Discogs Song Group matcher is uneccessarily saving songs one by one if Discogs match failed but already matched to Mb

Description

If both of these options are disabled:
Only allow match if all songs in grouping match to one album:No
Only allow match if all tracks in album were matched:No

Then if songs are (already) matched to mb but not Discogs then DiscogsSongGroupMatcher will be called, if this is unable to match the songs to Discogs it then check if each song is already matchedtoMb, if so it send to SongSaver, if not it send to MBSongMatcher.

The mistake is that if all songs are already matched to MB it should not send to SongSaver one by one, it should send the whole group. The mean currently that Song saving is much slower and also there is more chance of files being renamed so that they are split, even though Only allow match if all songs in grouping match to one album option is disabled so they can be split we want to avoid if possible.

Activity

Show:
IJabz
March 15, 2021, 12:04 PM

Done.

Fixed

Reporter

IJabz

Labels

None

Forum Username

ijabz

os

None

Components

Fix versions

Affects versions

Priority

Major